Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate shouldRespectMaxLoad #89

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Investigate shouldRespectMaxLoad #89

merged 2 commits into from
Oct 13, 2023

Conversation

mgrzaslewicz
Copy link
Contributor

No description provided.

dagguh and others added 2 commits October 13, 2023 15:07
@dagguh
Investigate why we see exceeded max load
66fe020 
```
com.atlassian.performance.tools.virtualusers.api.load.ThrottlingActionLoopLoadIT > shouldRespectMaxLoad FAILED
    java.lang.AssertionError:
    Expecting:
     <2400.4000666777797 over PT1H>
    to be between:
     [1800.0 over PT1H, 2400.0 over PT1H]
```
@mgrzaslewicz
Fix flaky ThrottlingActionLoopLoadIT.shouldRespectMaxLoad
0d6455f 
```
com.atlassian.performance.tools.virtualusers.api.load.ThrottlingActionLoopLoadIT > shouldRespectMaxLoad FAILED
    java.lang.AssertionError:
    Expecting:
     <2400.4000666777797 over PT1H>
    to be between:
     [1800.0 over PT1H, 2400.0 over PT1H]
        at com.atlassian.performance.tools.virtualusers.api.load.ThrottlingActionLoopLoadIT.assertLoadInRange(ThrottlingActionLoopLoadIT.kt:131)
        at com.atlassian.performance.tools.virtualusers.api.load.ThrottlingActionLoopLoadIT.shouldRespectMaxLoad(ThrottlingActionLoopLoadIT.kt:38)
```
@mgrzaslewicz mgrzaslewicz requested a review from a team as a code owner October 13, 2023 13:44
@mgrzaslewicz mgrzaslewicz enabled auto-merge (rebase) October 13, 2023 13:44
@mgrzaslewicz mgrzaslewicz merged commit bbc2b4e into master Oct 13, 2023
3 checks passed
@mgrzaslewicz mgrzaslewicz deleted the investigate-shouldRespectMaxLoad branch October 13, 2023 14:02
@dagguh dagguh changed the title Investigate should respect max load Investigate shouldRespectMaxLoad Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagguh dagguh dagguh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgrzaslewicz @dagguh