[BUGFIX] Order of partial absorption was not respected #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riclarsson
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in which the absorption by multiple species in
propmat_clearsky_fieldCalcwas jumbled.The update also rearranges a few for-loops to be able to collapse them into a single OpenMP block because the addition of a new outer-most loop anyways warranted a collapse statement.
Sadly, the commit also changes the formatting of much of the file because whatever tool was run before did not respect the default formatter we are using. (This was probably my fault to begin with, because my VSCODE did not actually load the default file for quite some time last year.)