V2.6.x addsungeo #770
Merged
V2.6.x addsungeo #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First of all, this is not a bug fix but a new feature in 2.6. I do not think it should be added to 2.6. Are you or anyone else really using |
|
I agree that the geometric properties can changed using python, but it it is not recommended to use python code inside an agenda. This function is needed, if you want to change the sun position or any other geometric property of the sun within an agenda like dobatch_calc_agenda or ybatch_calc_agenda. |
* Add additional checks * Update and bug fix documentation * Format code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a WSM to change the geometric varaibales of a sun.