Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise style handling and add dark theme #267

Merged
merged 6 commits into from
Jan 17, 2019

Conversation

lkluft
Copy link
Member

@lkluft lkluft commented Jan 17, 2019

This PR:

  • typhon.plots.styles raises a ValueError for unavailable styles.
  • It is possible to pass a list of style names to typhon.plots.styles and its methods.
  • typhon.plots.get_available_styles() is deprecated, use typhon.plots.styles.available instead.
  • Add a dark-colored theme typhon-dark.

It is possible to get/use several styles at a time by passing a list of
style names.
Add a property ``available`` to the style handler. Therefore the old
`get_available_styles()` function is deprecated.
@lkluft lkluft added enhancement Iterations on existing features API changes Affect user’s comprehension feature Brand new functionality labels Jan 17, 2019
@lkluft
Copy link
Member Author

lkluft commented Jan 17, 2019

AppVeyor fails because of an inconsistency between numpy and scikit-image (scikit-image/scikit-image#3586). As this is unrelated to my changes, I will merge the PR anyhow.

@lkluft lkluft merged commit ebfe0a3 into atmtools:master Jan 17, 2019
@lkluft lkluft deleted the add-dark-theme branch January 17, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API changes Affect user’s comprehension enhancement Iterations on existing features feature Brand new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant