Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions of QRNN code. #369

Merged
merged 19 commits into from
Sep 30, 2020
Merged

Extensions of QRNN code. #369

merged 19 commits into from
Sep 30, 2020

Conversation

simonpf
Copy link

@simonpf simonpf commented Sep 28, 2020

This extends the current implementation of QRNN to support both Pytorch and Keras
as backends. The QRNN class has been refactored to separate general QRNN functionality
from the underlying neural network model. Some functionality has been added e.g. computing
the posterior mean and sampling from a fitted Gaussian.

This work is part of an upcoming study on cloud correction at 183 GHz.

Copy link
Member

@olemke olemke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the two minor issues I mentioned and it's ok to merge from my side.

@simonpf
Copy link
Author

simonpf commented Sep 30, 2020

Thank you for the suggestions! Fixed!

Copy link
Member

@lkluft lkluft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@olemke olemke merged commit 309ef18 into atmtools:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants