Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customized run option #74

Merged
merged 27 commits into from
Apr 3, 2014
Merged

Customized run option #74

merged 27 commits into from
Apr 3, 2014

Commits on Apr 3, 2014

  1. Initial commit to my fork. In this I am mostly playing around with at… 

    …om to figure out how I might implement the run configuration feature.

I am wanting to have it be
1. Run the command by keybind etc
2. Dialog pops up with fields
3. Run normal script with those options
    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    a33bc0e View commit details
    Browse the repository at this point in the history

  2. Added a framework for storing options which are persistent for the li… 

    …fe of the view. Currently there is no frontened way to change them, but testing them by changing the code indicates that the optiosn properly change the running of the command.

The next step will be to implement a frontend to be able to change the options.

Rather than going for a customized run option, I am going to go in the direction of a command which will change the options that the normal run uses. This later can be extended to pull the default options from existing configuration files.
    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    909c41c View commit details
    Browse the repository at this point in the history

  3. Added the UI for configuring run options. It currently is not linked … 

    …to any backend and still needs some more work to display all necessary options.
    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    f088d4c View commit details
    Browse the repository at this point in the history

  4. I added better styling to the view using the style guide provided by … 

    …atom.

I also changed the behavior. I have a method which toggles the options on and off. The regular run insures that this is toggled off. When the option command is run it runs with this option toggled on. This should make sure that there is one script view per code file but allow easy changing between seeing it and not and allow for creation of a close button.

I am working on passing the values of the input into the option framework that I setup. The problem that I have right now is that when I type something into a text input, I cannot backspace the input. I don't know why this is happening but it seems related to a text input element. Once that is fixed, it should be easy to pass the arguments collected for configuration, add a save/close button, and be ready for some testing
    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    f1074d2 View commit details
    Browse the repository at this point in the history

  5. Completed hooking up the backend to the UI. You can now modify the cw… 

    …d, command arguments, and script arguments via cmd-shift-i.

Basic functionality works, but more work is needed on making the UI smoother.
    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    6c9005e View commit details
    Browse the repository at this point in the history

  6. Made changes on the css names to use all dash style instead of camel … 

    …case
    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    e9a8426 View commit details
    Browse the repository at this point in the history

  7. Changed .css calls to .show() and .hide(). Also used shorter notation… 

    … for if statement from if mode !=null to if mode?
    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    6c8d01a View commit details
    Browse the repository at this point in the history

  8. Removed debugging console.log statements

    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    ae86934 View commit details
    Browse the repository at this point in the history

  9. added myself as a contributor

    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    bad05dd View commit details
    Browse the repository at this point in the history

  10. removed unnecessary return statements

    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    5be1c21 View commit details
    Browse the repository at this point in the history

  11. renamed script:options to script:run-options

    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    1e85635 View commit details
    Browse the repository at this point in the history

  12. Changed the text from Script Arguments to Program arguments and added… 

    … a run button
    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    e7e1733 View commit details
    Browse the repository at this point in the history

  13. Simplified the toggle code to use jquery .toggle() and the ability to… 

    … force with .hide() or .show() still. Behavior should still be the same so far
    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    0bf623f View commit details
    Browse the repository at this point in the history

  14. Changed the flow so that running the options doesn't run the program.… 

    … It instead empties the panel and says its configuring options.

To run the script, there is a run button which will save the options, close the option dialog, and run the program.

For some reason I can't get it to appear without the script window already being open
    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    d25dc44 View commit details
    Browse the repository at this point in the history

  15. Cleaned up more from last commit removing unnecessary default arguments

    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    b41aab9 View commit details
    Browse the repository at this point in the history

  16. Added the options configuring to the script menu. 

    Fixed the bug where it would not run without script already being open, which was failing to rename teh activation event from script:run-options.

This now should be ready for some more review
    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    f1c5a59 View commit details
    Browse the repository at this point in the history

  17. Caught a bug where running wouldn't save the options first

    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    8b320e1 View commit details
    Browse the repository at this point in the history

  18. Changed the naming of options to avoid a name collision

    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    ab71393 View commit details
    Browse the repository at this point in the history

  19. collapsed multiple divs into one

    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    00414e9 View commit details
    Browse the repository at this point in the history

  20. Refactored the options view to a better name and separated it from th… 

    …e script view. Currently trying to get options to pass between views
    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    ff2a5b9 View commit details
    Browse the repository at this point in the history

  21. added a script options class

    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    44c3a4f View commit details
    Browse the repository at this point in the history

  22. Continued refactoring of view. Attempting to get single options objec… 

    …t to persist across all views. Currently it does not, perhaps the object is copied into each view on initialization instead of referecing the same object living in script.coffee. Removed the activation events in package.json as well
    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    264eae4 View commit details
    Browse the repository at this point in the history

  23. Used atom.emit on atom.on to communicate state effectively (options).… 

    … Discovered that options are not unique to a particular file, but are on an entire workspace which means they are not per file options. This needs to be addressed somehow
    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    c9f3fd5 View commit details
    Browse the repository at this point in the history

  24. removed unecessary action

    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    b1a3810 View commit details
    Browse the repository at this point in the history

  25. added small documentation note

    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    b05c9f5 View commit details
    Browse the repository at this point in the history

  26. fixes from the last rebase

    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    c9353f4 View commit details
    Browse the repository at this point in the history

  27. removed uneccesary statement

    @EntilZha
    EntilZha committed Apr 3, 2014
    Configuration menu
    Copy the full SHA
    8b2e31c View commit details
    Browse the repository at this point in the history