fix: fix addGitBashToEnv and addGitToEnv on Windows #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
force-pushed
the
windows-tests
branch
3 times, most recently
from
83060cc to
5475c82
Compare
Functional changes: - Include the mingw directory in the PATH (this directory contains many of the actual git functions, such as `git-pull`, `git-push`, and `git-upload-pack`). - Search `env.ProgramW6432` for Git before `env.ProgramFiles`, as `ProgramFiles` is not guaranteed to always point to the x64 Program Files directory. Technically, we should get the mingw path from `git --exec-path` (and this is what the GitHub package does), but that would mean making `git.addGitToEnv(env)` async, which would have been a much larger PR. From atom/apm#839 Co-Authored-By: Winston Liu <2766036+50Wliu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional changes:
Include the mingw directory in the PATH
(this directory contains many of the actual git functions,
such as
git-pull,git-push, andgit-upload-pack).Search
env.ProgramW6432for Git beforeenv.ProgramFiles,as
ProgramFilesis not guaranteed to always point tothe x64 Program Files directory.
Technically, we should get the mingw path from
git --exec-path(and this is what the GitHub package does), but that would mean
making
git.addGitToEnv(env)async,which would have been a much larger PR.
From atom/apm#839
Co-Authored-By: Winston Liu @50Wliu