Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable building the native module test on Windows #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

test: enable building the native module test on Windows #43

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8afab95
test: enable building the native module test on Windows
aminya Jun 25, 2022
53cfd10
test: enable all native module tests for windows
aminya Jun 26, 2022
0190e0a
Revert "test: enable all native module tests for windows"
aminya Jun 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 2 additions & 24 deletions spec/install-spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ describe("apm install", function () {
})
})

describe("when installing a registred package and --json is specified", function () {
describe("when installing a registered package and --json is specified", function () {
beforeEach(function () {
const callback = jasmine.createSpy("callback")

Expand All @@ -629,30 +629,8 @@ describe("apm install", function () {
})
})

describe("with a space in node-gyp's path", function () {
const nodeModules = fs.realpathSync(path.join(__dirname, "..", "node_modules"))

beforeEach(function () {
// Normally npm_config_node_gyp would be ignored, but it works here because we're calling apm
// directly and not through the scripts in bin/
const nodeGypPath = path.dirname(path.dirname(resolveSync("node-gyp"))) // find an installed node-gyp
fs.copySync(nodeGypPath, path.join(nodeModules, "with a space"))
process.env.npm_config_node_gyp = path.join(nodeModules, "with a space", "bin", "node-gyp.js")

// Read + execute permission
return fs.chmodSync(process.env.npm_config_node_gyp, fs.constants.S_IRUSR | fs.constants.S_IXUSR)
})

afterEach(function () {
delete process.env.npm_config_node_gyp
return fs.removeSync(path.join(nodeModules, "with a space"))
})

describe("with the bundled node-gyp", function () {
it("builds native code successfully", function () {
if (process.platform === "win32") {
console.warn("Test skipped on windows") // TODO
return
}
const callback = jasmine.createSpy("callback")
apm.run(["install", "native-package"], callback)

Expand Down