Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terminal manager #60

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Add terminal manager #60

wants to merge 7 commits into from

Conversation

aminya
Copy link
Member

@aminya aminya commented Apr 29, 2021

To fix #35

Copy pasted from Terminus.

@@ -0,0 +1,636 @@
const { CompositeDisposable } = require("atom")
const { $, View } = require("atom-space-pen-views-plus")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not use space pen views. I prefer etch.

@UziTech
Copy link
Member

UziTech commented Apr 30, 2021

I like the idea of a dropdown box instead of each terminal having it's own button. Or better yet we should do a select list similar to command palette. That way we can have names and color and search.

@idleberg
Copy link

idleberg commented May 4, 2021

I like the idea of a dropdown box instead of each terminal having its own button.

I agree with @UziTech. Just because there are dozens of terminal packages that do this, doesn't mean it's the right design pattern. Or from another perspective: there are already dozens of packages that do it this way, why should I choose this one?

Personally, I prefer dropdowns as well – that is if each terminal can have a name. This makes navigating between terminals much easier – just look at the name rather than remembering the position or the color of the button. The VSCode output console works like that:

image

I guess a dropdown also more accessible (as in a11y), which is something that's often forgotten in package UIs.

Or better yet we should do a select list similar to command palette

Great idea!

PS: I just noticed that some of these points have already been discussed #35

@aminya aminya closed this Jul 22, 2021
@aminya aminya closed this Jul 22, 2021
@aminya aminya reopened this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UI for switching to open terminals
3 participants