Make event listeners passive #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marking event listeners as passive, indicates that the callback will never call `event.preventDefault()`. This can improve scolling performance in many cases. For more information on passive event listeners see: https://developers.google.com/web/updates/2016/06/passive-event-listeners
lgeiger
added a commit
to lgeiger/atom-utils
that referenced
this pull request
Feb 15, 2019
This allows users to pass options to [`addEventListener`](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#Parameters). This is especially usefull when using passive event listeners which can greatly improve scrolling performance. See atom-minimap/minimap#683
lgeiger
added a commit
to lgeiger/atom-utils
that referenced
this pull request
Feb 15, 2019
This allows users to pass options to [`addEventListener`](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#Parameters). This is especially usefull when using passive event listeners which can greatly improve scrolling performance. See atom-minimap/minimap#683
|
🎉 This PR is included in version 4.30.0 of minimap-plus 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking event listeners as passive, indicates that the callback will never call
event.preventDefault(). This can improve scolling performance in many cases.For more information on passive event listeners see: https://developers.google.com/web/updates/2016/06/passive-event-listeners