Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Upgrade npm to 6.2.0 to fix Windows long file path issues #803

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

daviwil
Copy link
Contributor

@daviwil daviwil commented Aug 6, 2018

Description of the Change

This change updates apm to use npm 6.2.0 to benefit from some major dependency restructuring and flattening that shaved about 60 characters off of npm's directory tree paths, specifically to aid with installing Node.js on Windows.

Since we've been fighting with "path too long" errors with Squirrel for a long time, this new version of npm is a welcome relief and a path forward to finally deliver side-by-side Atom release channel installations on Windows.

Alternate Designs

I also tried running npm dedupe in Atom's apm folder in various different ways and it either broke apm, broke Atom's app packaging, or had no real effect. Updating to npm 6.2.0 is the only thing that brought results.

I also tried updating to npm 6.3.0 but ran into some issues with apm after doing that, so it's probably better to hold off for now.

Benefits

Possible Drawbacks

Minor bugs introduced by 6.2? So far everything seems solid.

Applicable Issues

@daviwil daviwil requested a review from smashwilson August 6, 2018 14:18
Copy link
Contributor

@smashwilson smashwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I also tried updating to npm 6.3.0 but ran into some issues with apm after doing that, so it's probably better to hold off for now.

Can you open an issue with some details about that one? I'd rather not get stuck being too far behind again...

@daviwil
Copy link
Contributor Author

daviwil commented Aug 6, 2018

Yeah I'll see if I can track down exactly what the issue was and then file an issue.

@daviwil daviwil merged commit 574229f into master Aug 6, 2018
@daviwil daviwil deleted the dw-npm-6.2 branch August 6, 2018 14:24
@daviwil daviwil mentioned this pull request Aug 6, 2018
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants