This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Use definition to indicate out-of-project files with server support #253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language servers can support out of project files, ie RLS dependencies which cargo puts somewhere in
~/.cargo/
. However, currently ide-rust cannot support any LSP functionality for dependency sources or the rust std library because atom-languageclient does not know these files may be of interest to the RLS.This change optionally uses
textDocument/definition
responses to imply a server's support of the returned out-of-project source directories.When matching a the editor's file path to a server these implications are taken into account if we cannot otherwise find a server from the path.
The method
serversSupportDefinitionDestinations(): boolean
is overridden by the client concrete class to opt into this behaviour.Fixes #244
Using this technique is very effective for ide-rust
This feature is also available in my fork: