This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in the latest changes to @atom/watcher.
Notably, bring in atom/watcher#123, which introduces an alternative, environment variable-based mechanism to establish logging for the main thread, worker thread, or polling thread. This should be useful when we need to collect data about crashes that occur early in the module's lifecycle, before the threads and message queues are established.
WATCHER_LOG_MAIN
WATCHER_LOG_WORKER
WATCHER_LOG_POLLING
All of these are interpreted the same way:
stdout
stderr
$ WATCHER_LOG_MAIN=stdout atom --foreground --wait ${OTHER_ARGS}
@as-cii @maxbrunsfeld: Once this is in, I'd be very interested to know what you see in the main thread logs when atom/watcher#120 or a lock-up happens. We should be able to see what kind of message it's trying to send to the worker thread that's causing your crash.