This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Make way for variable completions #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests will be on their way as soon as I get the time. |
winstliu
reviewed
Jan 30, 2017
| .concat(@getTagCompletions(request)) | ||
| else if not isSass and @isCompletingName(request) | ||
| completions = @getPropertyNameCompletions(request) | ||
| if not @isCompletingCustomProperty(request) |
There was a problem hiding this comment.
Apologies! This is my first shot at coffeescript. It's a frightening departure from Javascript 😆
| isCompletingCustomProperty: ({scopeDescriptor}) -> | ||
| scopes = scopeDescriptor.getScopesArray() | ||
|
|
||
| (hasScope(scopes, 'variable.css')) or |
There was a problem hiding this comment.
It looks like these have one extra layer of parentheses that can be removed.
|
This fails when you're typing against a colon as in the following scenario: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
getSuggestionsnow performs an initial check for scopes indicating custom properties, and only drops into resolving additional suggestions if this is not the case.Benefits
This allows tokens resolved as per atom/language-css#102 to be available in the custom property scopes and no other tokens (AFAIK, no other suggestions are applicable here).
Applicable Issues
#56
atom/autocomplete-plus#740