-
Notifications
You must be signed in to change notification settings - Fork 264
Exact match suggestions aren't shown when there's more than one suggestion #1018
Comments
Thanks for reaching out -
Just to clarify, you're talking specifically about the case where you'll need to hit enter for a newline but you have Atom set use enter for confirming a suggestion? |
Not just the enter case, this happens for using tab to confirm a suggestion as well. For example, if I want to type the word technology and then a tab, it changes to technologically. |
Thanks for clarifying - for this situation where the setting you have to confirm a suggestion can conflict with what you want to do (i.e. actually tab or enter), this sounds like what's described in #943. We'll close in favor of that issue and you can subscribe there if you'd like (though let me know if misunderstood what you've described). |
Hi @rsese, thanks for that consideration, but this issue is different, and that what I've reported is a bug and not a user preference for confirming a suggestion. The reason is because while I am typing the word technology, up until I type the final 'y', the word is the top suggestion. For example, if I type "technolog" and then hit tab or enter, it places with the word "technology". However, if I completely type out the word, "technology" then it is removed from the suggestion list altogether. But it should still be the top suggestion - I've correct spelled that word, so it should be the obvious and first choice. Users expect that if they type a properly spelled word and then hit enter or tab that it will not be replaced with a different word. |
Oh ok I think i see what you're saying - are these steps to reproduce accurate?
At this point, you expect |
Yes, exactly. And not just any suggestion but the first suggestion, so if I
hit (enter | tab | keystroke) the word I have correctly spelled isn't
changed. I think by default if I have correctly typed a word then it should
require me to take an additional step (like the down arrow) to select a
different suggestion.
You can also reproduce with common words such as dog (changed to doing) or
doing (changed to dotting) or dotting (changed to demonstrating)
…On Tue, Jan 8, 2019 at 6:21 PM Robert Sese ***@***.***> wrote:
Oh ok I think i see what you're saying - are these steps to reproduce
accurate?
1. create a new file with this content:
technology is changed to technologically
1. hit enter and type technology
At this point, you expect technology to be an autocomplete suggestion,
actual behavior is technologically is the only suggestion?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1018 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABL2Eox6Rqju-MhPGNkNkIQ9TRvW-wm3ks5vBVIbgaJpZM4ZbLhF>
.
|
Thanks for clarifying - I saw this old pull request (#547) that seems like it was supposed to make it so an exact match will be removed if it's the only suggestion, so I think I would expect "technology" to still be an option in our example above? Something could have changed in the meantime of course. |
Edit by @rsese to add more details based on comments
technology
Expect
technology
to be an autocomplete suggestion, actual behavior istechnologically
is the only suggestion.Description
Correctly spelled words are being changed to other longer words that I don't want.
For example, "technology" is changed to "technologically"
This happens when I want to go to a newline, without adding a period or other punctation at the end of the line. This often happens for bulleted lists. I know I can change the Keymap for Confirming A Suggestion to only Tab, but I do want it to correct misspelled words on Enter
Steps to Reproduce
Expected behavior: the word "technology" is left unchanged
Actual behavior: the word changes to "technologically"
Reproduces how often: 100%
Versions
autocomplete-plus: 2.41.0
The text was updated successfully, but these errors were encountered: