Revert changes from #43 #45
Conversation
Reverts the changes from atom#43 per atom#43 (comment).
|
@joefitzgerald, @thomasjo Any reason this hasn't been merged yet? The changes in #43 were supposedly causing issues with packages, and have not yet been reverted... |
|
I don't recall anyone saying this caused any issues. I'm not against reverting it, but now we're at least consistent across platforms. My point was always that we should be consistent. The CI scripts are a royal mess and desperately needs to be refactored... it's on my list, but likely won't happen until September. I'm leaning towards leaving things as they are now unless someone can point me to actual evidence that what we have now is causing problems. I'm not looking for theoretical problems, only real and current problems. |
|
Okay, closing this then 😉. |
|
As a note, #49 essentially did this reversion if the flag to use the bundled |
Reverts the changes from #43 per #43 (comment).