This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Hacking on Atom Core: Update build requirements to be accurate #630
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d378e0e
Hacking on Atom Core: Update Python, VS info
DeeDeeG 3932f5a
Hacking on Atom Core: Update Node, NPM versions
DeeDeeG d35008d
hacking-on-atom-core.md: No Python3 on Windows
DeeDeeG 1ba2105
hacking-on-atom-core.md: `windows-build-tools` is great
DeeDeeG 88cf835
hacking-on-atom-core.md: Update windows info
DeeDeeG 7dcf363
hacking-on-atom-core.md: Python 2.6, 2.7 and 3.5+
DeeDeeG c55744a
hacking-on-atom-core.md: 7-Zip install not needed
DeeDeeG 53ec234
hacking-on-atom-core: Suggest windows-build-tools
DeeDeeG ae35fc0
atom-core: Tweak windows-build-tools install
DeeDeeG b72c20a
hacking-on-atom-core: No Visual Studio 2019
DeeDeeG 50f9a18
hacking-on-atom-core: Suggest npm 6.12 or later
DeeDeeG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use Node 12 in our CI builds. Shouldn't that be the supported version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 is still an officially supported Long Term Support version for now: https://nodejs.org/about/releases/
(Until the end of April in 2021)