Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Update yubikiri to v2.0.0 #2010

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Update yubikiri to v2.0.0 #2010

merged 1 commit into from
Mar 8, 2019

Conversation

BinaryMuse
Copy link
Contributor

Description of the Change

Heya, folks!

I've just updated Yubikiri to v2.0.0; most notably, this fixes a bug where values calculated from function resolvers might mistakenly be calculated more than once (e.g. this test would fail).

Screenshot/Gif

N/A

Alternate Designs

N/A

Benefits

Fixes potential bugs as described above.

Possible Drawbacks

Yubikiri v2.0.0 was a rewrite from v1.0.0 (thus the major version bump), so there could be unforseen bugs that arise. That said, the test suite passes, and the updated package is working on a similar PR for electronjs.org.

Applicable Issues

N/A

Metrics

N/A

Tests

N/A

Documentation

N/A

Release Notes

N/A

User Experience Research (Optional)

N/A

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #2010 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2010   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files         189      189           
  Lines       11244    11244           
  Branches     1634     1634           
=======================================
  Hits        10410    10410           
  Misses        834      834

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f6679...20f3fe1. Read the comment docs.

Copy link
Contributor

@smashwilson smashwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sweet, thanks!

@smashwilson smashwilson merged commit 40e469e into master Mar 8, 2019
@smashwilson smashwilson deleted the mkt/update-yubikiri-2-0-0 branch March 8, 2019 13:12
@smashwilson smashwilson mentioned this pull request Apr 8, 2019
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants