Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

#error directive doesn't handle ' or " correctly #233

Open
sean-mcmanus opened this issue Apr 27, 2017 · 4 comments · May be fixed by #251
Open

#error directive doesn't handle ' or " correctly #233

sean-mcmanus opened this issue Apr 27, 2017 · 4 comments · May be fixed by #251
Labels
bug

Comments

@sean-mcmanus
Copy link

sean-mcmanus commented Apr 27, 2017 •
edited
Loading

Use
#error doesn't

#error need "fixing

int j; '
The ' and " should not cause string highlighting until the next matching closing ' or " is found. Only the entire error line should be treated as a string.
@sean-mcmanus sean-mcmanus mentioned this issue Apr 27, 2017
Closed
@winstliu winstliu added the bug label Apr 27, 2017
@BillDenton
Copy link

Any news on this? I've just tripped over it again.

@sean-mcmanus
Copy link
Author

I don't have any news.

fnadeau pushed a commit to fnadeau/language-c that referenced this issue Oct 31, 2017
🐛 atom#233
6b00fcb 
Fix highlight of error directive
@fnadeau fnadeau linked a pull request Oct 31, 2017 that will close this issue
Open
fnadeau pushed a commit to fnadeau/language-c that referenced this issue Nov 6, 2017
🐛 atom#233
80b5cca 
Fix issue with spec.coffee failing. Message were not
properly tagged.
@beckerzito
Copy link

Any news on this issue?

@sean-mcmanus
Copy link
Author

The pull request with the tentative fix is #251 , but apparently some issue was found that hasn't yet been resolved.

@Ben3eeE Ben3eeE mentioned this issue Nov 2, 2018
Merged
2 tasks
@jeff-hykin jeff-hykin mentioned this issue Mar 16, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve #error and #warning tokenization fnadeau/language-c
4 participants
@winstliu @BillDenton @sean-mcmanus @beckerzito