Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Highlight div_t #133

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Highlight div_t #133

merged 1 commit into from
Feb 9, 2017

Conversation

omern1
Copy link
Contributor

@omern1 omern1 commented Apr 4, 2016

Partially fixes #126.

@omern1 omern1 changed the title Fixes https://github.com/atom/language-c/issues/126 Partially fixes https://github.com/atom/language-c/issues/126 Apr 4, 2016
@winstliu
Copy link
Contributor

winstliu commented Apr 7, 2016

Hi @nabeelomer, can you elaborate on how this only "partially fixes" #126? Is there another place that needs changes?

@omern1
Copy link
Contributor Author

omern1 commented Apr 9, 2016

@50Wliu I'm extremely embarrassed. I read the issue wrong. I thought both div_t and the function div need to be highlighted.

@winstliu winstliu changed the title Partially fixes https://github.com/atom/language-c/issues/126 Highlight div_t Apr 9, 2016
@winstliu
Copy link
Contributor

It looks like div_t only exists in C++ - can you please move this to the C++ file instead? Thanks.

@M4GNV5
Copy link
Contributor

M4GNV5 commented Feb 8, 2017

Nope, div is part of the C standard, here's the man page from section 3: http://man7.org/linux/man-pages/man3/div.3.html

however maybe these should also be added: ldiv_t, lldiv_t and imaxdiv_t

@winstliu
Copy link
Contributor

winstliu commented Feb 9, 2017

Yes, it looks like I was mistaken. I will merge this now - @nabeelomer or @M4GNV5 feel free to create a new PR adding the other types.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add div_t to the list of recognized standard library types
3 participants