Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

🐛 Fix #227 #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🐛 Fix #227 #229

wants to merge 1 commit into from

Conversation

jerrykal
Copy link
Contributor

Fix #227 by change foldEndPattrn from (?<!\\*)\\*\\*/|^\\s*\\} to (?<!\\*)\\*\\}

@winstliu
Copy link
Contributor

I don't think this fix is correct. The previous implementation had the folding end at either a closing comment */ or a closing brace }. This new implementation ends the fold at *}, which I'm pretty sure is not valid in C.

@jerrykal
Copy link
Contributor Author

jerrykal commented Apr 12, 2017

@50Wliu But it work very well for me.

(?<!\\*)\\*\\*/|^\\s*\\}:

screen shot 2017-04-12 at 09 20 18

(?<!\\*)\\*\\}:

screen shot 2017-04-12 at 09 18 04

@winstliu
Copy link
Contributor

The fact that it works does not mean that it is correct.

@jerrykal
Copy link
Contributor Author

So, what can I do 🤓

@winstliu
Copy link
Contributor

I don't know. I don't have any experience with folding patterns, so this will be put on hold until I do or someone else who has experience reviews it.

@jerrykal
Copy link
Contributor Author

Okay 👌 , got it 👍 .

@jerrykal
Copy link
Contributor Author

@50Wliu By the way, remove foldEndPattern work for me too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants