This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caveat: I'm not sure how to test this. I'm new to Atom
Requirements
Description of the Change
Try to support embedded hbs via template literals, as is demonstrated via:
https://hljs-glimmer.nullvoxpopuli.com/?sample=jsWithHbs
(this is used everywhere in testing, too)
Alternate Designs
?
Benefits
Handlebars developers (and consequently ember developers, even though ember doesn't use handlebars), will get syntax highlighting on hbs template strings
Possible Drawbacks
people get color?
Applicable Issues