Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add HAR to JSON filetypes #69

Closed
wants to merge 1 commit into from
Closed

Add HAR to JSON filetypes #69

wants to merge 1 commit into from

Conversation

wesinator
Copy link

Description of the Change

Add HTTP archive extension to the filetypes.

@lee-dohm
Copy link
Contributor

Thanks for your contribution!

Because you can customize how Atom recognizes files as specific languages, we are only accepting extensions that are very common. Thanks again for your help and your passion for Atom!

@lee-dohm lee-dohm closed this Jan 15, 2019
@wesinator
Copy link
Author

@lee-dohm This is a common JSON format extension that was added to linguist - github-linguist/linguist#4369

@lee-dohm
Copy link
Contributor

linguist has a different architecture than language recognition in Atom. Because it is a monolithic system, they can test all the permutations of language recognition collisions and ensure that the right language is chosen. But because Atom is an extensible architecture, adding an extension to a built-in language could prevent a package that a user has installed from using that extension simply because it is loaded first. So we have to be a bit more careful about adding extensions than linguist does.

@wesinator
Copy link
Author

But because Atom is an extensible architecture, adding an extension to a built-in language could prevent a package that a user has installed from using that extension simply because it is loaded first. So we have to be a bit more careful about adding extensions than linguist does.

I understand that, but the only package that highlights .har is https://github.com/caleb531/language-har/blob/master/grammars/har.cson, which just loads this grammar.

@rsese rsese mentioned this pull request Mar 14, 2019
@wesinator

This comment has been minimized.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants