Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Stop matching URLs at first closing parenthesis #76

Merged
merged 1 commit into from
May 25, 2017
Merged

Conversation

winstliu
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Don't be overeager - stop matching URL strings at the first closing parenthesis. Fixes the case when there's multiple closing parentheses on the same line, such as one to close the url function and another to close a format function.

Alternate Designs

Changing the pattern to use a match instead of a begin/end pair. Decided to keep the change minimal.

Benefits

No more buggy highlighting when specifying a format after a URL.

Possible Drawbacks

None.

Applicable Issues

Fixes #51, supersedes and closes #54

@winstliu winstliu merged commit c7ae276 into master May 25, 2017
@winstliu winstliu deleted the wl-url-strings branch May 25, 2017 02:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

font-face->src->url() problematic without quotes
1 participant