This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Stop matching URLs at first closing parenthesis #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Don't be overeager - stop matching URL strings at the first closing parenthesis. Fixes the case when there's multiple closing parentheses on the same line, such as one to close the
url
function and another to close aformat
function.Alternate Designs
Changing the pattern to use a
match
instead of a begin/end pair. Decided to keep the change minimal.Benefits
No more buggy highlighting when specifying a format after a URL.
Possible Drawbacks
None.
Applicable Issues
Fixes #51, supersedes and closes #54