A certain way of writing Ternary removes Syntax Highlighting of null

[finn-matti]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Null value looses coloration when colon is written on same line

Steps to Reproduce

See screenshots.

Actual behavior:

Expected behavior:

Reproduces how often:

Every time.

Versions

• Atom : 1.45.0
• Electron: 4.2.7
• Chrome : 69.0.3497.128
• Node : 10.11.0
• macOS: 10.15.4

Additional Information

I raised the same issue earlier here but was referred to report it here. The maintainer said:

Issue belongs to this repository: https://github.com/atom/language-php
And is caused by null : interpreted as goto label.

[finn-matti]

@darangi Why was this closed? Could you not reproduce it? A comment would have been nice.

EDIT: Disregard and apologies. I got confused by the old issue and thought this one got closed. But you just added a label.

[Aerijo]

This issue is not closed

[lee-dohm]

Are the labels on the screenshots backward? Is the complaint that the null keyword is colored? Or not colored?

[finn-matti]

The complaint is that null should be colored but is not.

…

On Wed 1. Apr 2020 at 20:19 Lee Dohm ***@***.***> wrote: Are the labels on the screenshots backward? Is the complaint that the null keyword *is* colored? Or *not* colored? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#386 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANMMCTMZH7BNZUSFXM3BM33RKNZRNANCNFSM4LUBFC2A> .

[KapitanOczywisty]

@lee-dohm null : is treated as goto label and not colored as keyword + ternary.

[sadick254]

Using tree-sitter-php would solve this issue. tree-sitter-php produces a consistent syntax tree irregardless of formatting

// example 1
$test = true ? null : 'hello world';
// example 2
$test = true ? null : 
  'hello world';
// example 3
$test = true ? 
  null : 
  'hello world';

All the examples will produce

(program (php_tag) 
  (expression_statement 
    (assignment_expression 
      left: (variable_name (name)) 
      right: (conditional_expression 
      condition: (boolean) 
      body: (null) 
      alternative: (string)))) (text_interpolation))

There is a PR already to add tree-sitter-php grammar

[KapitanOczywisty]

@sadick254 PR is out of date and not complete. Above that, It will not solve issue in vscode.

It will be very hard to fix this issue since TM grammar is rather hopeless when comes to multi-line rules. I was trying to find solution to this, but failed.

[KapitanOczywisty]

@finn-matti @sadick254 This took embarrassingly long time (a few hours at least, this time..), but I've fixed this and there will be PR shortly ;)

This wasn't that complicated after all, basically I had to make goto label rule with higher priority in ternary and what important without colon itself.