Upgrade packages that use old versions of graceful-fs #10
Conversation
There have been fairly significant changes to the Less.js code since the previously used version, so this commit was non-trivial to develop. Notably the use of `Parser` was deprecated and now requires the use of `less.render` instead.
I completely missed that one... could have saved myself a few hours 😬 |
|
Thanks @thomasjo! |
|
@thomasjo
Another edit: yeah, no. It's not working. I was out of dev mode after restarting Atom and didn't notice. |
|
If you're trying to use optional in an Atom package, it's because less-cache was never upgraded in Atom. It was upgraded recently though so you should be able to start using it in Atom 1.17.0 or 1.16.0. |
|
@50Wliu yep, I was out of dev mode after updating Atom and didn't notice. That's why I wasn't getting compile errors when modifying my source code. Thanks for pointing it out! 😅 Also, it doesn't seem to be in included 1.16.0-beta0 😞 |
The main upgrades here are the various Grunt packages and Less.js, all of which relied on deprecated versions of graceful-fs. Node.js v6 and later requires graceful-fs v4 (or newer).
I also bumped the other packages, and alphabetized the package lists in
package.json.This PR is required as part of atom/atom#12176.
/cc @atom/feedback @kevinsawicki @nathansobo