This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add guard against null to match remainder of calls in file #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @shiftkey this was found via our internal codeql checks. |
sergiou87
suggested changes
Nov 9, 2021
There was a problem hiding this comment.
Nice catch! Only one nit around messaging the error, if it sounds reasonable.
Off-topic: @deepak1556 I love your profile picture 😍 🥲
Co-authored-by: Sergio Padrino <sergiou87@github.com>
|
The Ubuntu check is not passing because Thank you for the fix!!! 🙌 |
Merged
This was referenced Sep 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the same guard against NULL that exists in the other functions in this file.