This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Adding, Changing, or Removing a Feature
Issue or RFC Endorsed by Atom's Maintainers
na
Description of the Change
Updates Travis CI to build and mac and windows too, as well as maximising parallel compilation and removing unnecessary config values.
It's good to build and test for these platforms, as native code (especially a third party module) may have platform specific issues.
Alternate Designs
It technically works as is, but this should make it catch more errors
Possible Drawbacks
Goes from 4 builds to 12; this can be cut to 9 if Node 6 support is dropped (Atom is on 10, and NodeJS is about to drop support for version 8).
Verification Process
Tests on a fork, and this PR itself. I anticipate an error in Node 6 with Windows. (Edit: This is the only failing job).
Release Notes