This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Use 'Nan::Set' #135
Open
Use 'Nan::Set' #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following errors.
```
../src/main.cc:138:25: error: no matching member function for call to 'Set'
misspelled_range->Set(Nan::New("end").ToLocalChecked(), Nan::New<Integer>(end));
```
The following warning. ``` ../src/worker.cc: In member function ‘virtual void CheckSpellingWorker::HandleOKCallback()’: ../src/worker.cc:44:25: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations] callback->Call(2, argv); ```
abetomo
force-pushed
the
feature/fix_compile_errors
branch
from
298cc77 to
d1fcd7f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix
Identify the Bug
#134
Description of the Change
Since
obj->Setis an error, we useNan::Set.(#120 also seems to have the same fix in it.)
Alternate Designs
#130 is a similar fix.
I thought it would be better to use
Nan::Set.Possible Drawbacks
Verification Process
I compiled and ran the unit tests.
Release Notes