This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Handle escaped characters in tab-stop placeholder content #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| variableContent = content:(variable / variableContentText)* { return content; } | ||
| variableContentText = text:variableContentChar+ { return text.join(''); } | ||
| variableContentChar = !variable char:[^}] { return char; } | ||
| start |
There was a problem hiding this comment.
Would it be possible to have a more minimal diff here?
The current diff makes it looks like the entire peg was rewritten, yet things like simpleTabStop appear to be the same, just reformatted.
|
Rolled back and now only do the minimal changes |
kevinsawicki
added a commit
that referenced
this pull request
Apr 6, 2015
Handle escaped characters in tab-stop placeholder content
Thanks so much for doing this, makes it super easy to review. Also thanks for this fixing this issue 🚢 |
thomasjo
added a commit
to thomasjo/language-latex
that referenced
this pull request
Apr 13, 2015
Resolves the backslash issue caused by a breaking change that was introduced in snippets in atom/snippets#123. Fixes area#127
thomasjo
added a commit
to thomasjo/language-latex
that referenced
this pull request
Apr 13, 2015
Resolves the backslash issue caused by a breaking change that was introduced in snippets in atom/snippets#123. Fixes area#30
This was referenced Apr 13, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim to resolve #60.
To include } in your placeholder content selection, escape it with two \ :