This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix browser version #89
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
commented
Dec 5, 2020
| @@ -83,7 +84,7 @@ void change_set_noop(Patch::Change &change, T const &) {} | |||
| EMSCRIPTEN_BINDINGS(Patch) { | |||
| emscripten::class_<Patch>("Patch") | |||
| .constructor<>() | |||
| .constructor<emscripten::val>(WRAP_STATIC(&constructor), emscripten::allow_raw_pointers()) | |||
| .constructor(WRAP_STATIC(&constructor), emscripten::allow_raw_pointers()) | |||
There was a problem hiding this comment.
This change is related to emscripten-core/emscripten#11274.
Currently, the template parameters seem to be deduced from the given constructor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #88
Description of the change
This fixes the browser version of superstring.
Closes #79
Remaining:
This currently builds locally without issues.
However, the browser's tests don't pass. emscripten does not generate binding for TextBuffer. I think we need to instantiate wasm before being able to access that.