[Linux][1.19.0-beta1] Closing tab with middle mouse pastes in next tab

[hultberg]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Same as #52, but this time I'm unable to reproduce this on 1.18, but able on 1.19.

Steps to Reproduce

1. Open two files in the editor
2. Close one tab with middle mouse button
3. Observe that you have just pasted in what-ever was in your clipboard in the next file.

Make sure you have something in the clipboard.

Expected behavior: The tab should just be closed.

Actual behavior: Tab closes and content from my clipboard is pasted.

Reproduces how often: Always

Versions

1.18:

~ ᐅ atom --version
Atom    : 1.18.0
Electron: 1.4.16
Chrome  : 53.0.2785.143
Node    : 6.5.0

1.19:

~ ᐅ atom-beta --version
Atom    : 1.19.0-beta1
Electron: 1.6.9
Chrome  : 56.0.2924.87
Node    : 7.4.0

Additional Information

Related to #52

[winstliu]

Most likely caused by the Electron upgrade; specifically the underlying changes to how Chrome handles middle-button-paste on Linux.

[ungb]

I'm able to repro this issue with the repro steps provided.

[ungb]

This looks related to electron upgrade as it also caused regression with double pasting on middle clicking(atom/atom#8648) that was fixed with atom/atom#14987.

[t-bltg]

Is there a hotfix for this ? I keep pasting everywhere on closing tabs ...

[t-bltg]

I've been playing around in dev mode atom -d, and it seems that removing event.preventDefault()) and returning false in TabBarView.prototype.onMouseDown in atom-beta/resources/app/node_modules/tabs/lib/tab-bar-view.js prevents the bug (following https://stackoverflow.com/q/1357118/5584077)

tab-bar-view.js

TabBarView.prototype.onMouseDown = function(event) {
  var ref, tab;
  tab = this.tabForElement(event.target);
  if (!tab) {
    return;
  }
  if (event.which === 3 || (event.which === 1 && event.ctrlKey === true)) {
    if ((ref = this.rightClickedTab) != null) {
      ref.element.classList.remove('right-clicked');
    }
    this.rightClickedTab = tab;
    this.rightClickedTab.element.classList.add('right-clicked');
    return event.preventDefault();
  } else if (event.which === 1 && !event.target.classList.contains('close-icon')) {
    return setImmediate((function(_this) {
      return function() {
        _this.pane.activateItem(tab.item);
        if (!_this.pane.isDestroyed()) {
          return _this.pane.activate();
        }
      };
    })(this));
  } else if (event.which === 2) {
    this.pane.destroyItem(tab.item);
    // return event.preventDefault();  // <====== comment
    return false;                      // <====== added
  }
};

so a patch on atom/tabs could be something like
tab-bar-view.coffee

diff --git a/lib/tab-bar-view.coffee b/lib/tab-bar-view.coffee
index eb5a2c2..0bcf6a5 100644
--- a/lib/tab-bar-view.coffee
+++ b/lib/tab-bar-view.coffee
@@ -415,7 +415,8 @@ class TabBarView
         @pane.activate() unless @pane.isDestroyed()
     else if event.which is 2
       @pane.destroyItem(tab.item)
-      event.preventDefault()
+      # event.preventDefault()
+      false
 
   onDoubleClick: (event) ->
     if tab = @tabForElement(event.target)

can anyone try this (i'm on atom-beta7 btw) ?

[lammas]

Can confirm that this also worked for 1.19.0-beta4