This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Don't notify observers of onDidChangeText after an empty transaction
#230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Atom we are using transactions to emit a single
onDidUpdateevent on marker layers when multiple markers are manually moved at the same time.Previously, even when not making any changes to the buffer during one of these transactions, we would emit an
onDidChangeTextevent with an empty list of changed regions. Packages could, however, rely on this event to perform destructive actions, and that should not happen as a result of a simple cursor movement. This was causing some test failures in atom/atom#12696.For this reason, with this pull request we are changing the
onDidChangeTextevent to be emitted only when the buffer is modified./cc: @nathansobo