This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Re-implements hiding behavior based on promise to fix timing error. #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaotmartins
changed the title
Jelisacooper4
approved these changes
Nov 25, 2021
|
Any progress on this? 😭 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Re-implemented hiding code to perform conditional hiding as a callback of treeViewOpenPromise. This fixes an error where we might have attempted to hide the pane before it existed (usually only happened when Atom was started up with a clean profile).
Alternate Designs
None.
Benefits
Tree-view hiding works even when there are a few timing differences in the pane initialization.
Possible Drawbacks
None.
Applicable Issues
See comments to #1389