feat: add signature verification to node response #105
+109
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maschad
reviewed
Feb 10, 2025
| @@ -332,6 +335,7 @@ pub async fn confidential_image_generations_create( | |||
| ) | |||
| )] | |||
| #[allow(clippy::too_many_arguments)] | |||
| #[allow(clippy::significant_drop_tightening)] | |||
There was a problem hiding this comment.
I've allowed this as refactoring would be quite substantial, see #210
jorgeantonio21
commented
Feb 10, 2025
| @@ -463,6 +462,11 @@ impl Stream for Streamer { | |||
| } | |||
| } else if let Some(usage) = chunk.get(USAGE) { | |||
| self.status = StreamStatus::Completed; | |||
| let _ = { | |||
| let guard = self.sui.blocking_read(); | |||
There was a problem hiding this comment.
How safe is it to have a blocking_read in an async stream ?
Another possibility is poll::pending and add logic to the poll next method to handle when a signature is ready, but that's a bit too much of hassle.
There was a problem hiding this comment.
That's a good point, we actually try caching the keystore when creating the Streamer to avoid locking during stream processing, wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.