Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add country to nodes #61

Merged
merged 2 commits into from
Dec 17, 2024
Merged

feat: add country to nodes #61

merged 2 commits into from
Dec 17, 2024

Conversation

Cifko
Copy link
Collaborator

@Cifko Cifko commented Dec 13, 2024

Review #60 first, and after merge this can be reviewed.

Add country column to nodes. So we can have a distribution in the dashboard.

@Cifko Cifko requested a review from jorgeantonio21 December 13, 2024 12:58
@Cifko Cifko force-pushed the add-country-to-nodes branch from 470bac0 to 7fa12b9 Compare December 13, 2024 14:29
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's first merge the previous PR, address the comments and then merge

atoma-state/src/types.rs Show resolved Hide resolved
atoma-state/src/state_manager.rs Show resolved Hide resolved
atoma-state/src/types.rs Show resolved Hide resolved
@Cifko Cifko force-pushed the add-country-to-nodes branch 2 times, most recently from 14ad6ae to bfea478 Compare December 16, 2024 18:35
@Cifko Cifko force-pushed the add-country-to-nodes branch from bfea478 to 9ea3ea0 Compare December 17, 2024 06:35
@Cifko Cifko force-pushed the add-country-to-nodes branch from 976c355 to fc49bef Compare December 17, 2024 06:42
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeantonio21 jorgeantonio21 merged commit b8d8886 into main Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants