Make Test Generation work with a custom Z3 version #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should allow test generation to work with a custom Z3 binary and options. I also did some refactoring to make addition of new options easier in the future:
Basically, aside from adding a new option to the respective Options list, the only other requirement is to make sure that the new option and any side effects of setting that option are copied appropriately in the
CopyForProceduremethod ofSource/DafnyTestGeneration/GenerateTestsCommand.cs.I am not sure what is the appropriate way of copying the
BoogieArgumentsandSolverPluginoptions (do they have side effects?), so I disable them in the PR, but the only requirement is to make sure these options are appropriately copied in theCopyForProceduremethod.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.