Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only burn when the remaining value equals to the original #229

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

wizz-wallet-dev
Copy link
Collaborator

@wizz-wallet-dev wizz-wallet-dev commented Aug 8, 2024

Allocating NFT value from 1000 to <1000 now considered as burned. The request changes the condition to burn only when no values are allocated.

The request also fixes incorrect NFT coloring output when decoding custom coloring in the blueprint builder.

  • Verify on Testnet
  • Verify on Mainnet

@wizz-wallet-dev wizz-wallet-dev marked this pull request as ready for review August 12, 2024 12:55
@wizz-wallet-dev wizz-wallet-dev changed the base branch from master to develop August 12, 2024 12:56
@shadowv0vshadow
Copy link
Collaborator

LGTM!

@wizz-wallet-dev wizz-wallet-dev merged commit e648d9b into develop Aug 12, 2024
4 checks passed
@wizz-wallet-dev wizz-wallet-dev deleted the fix/custom-coloring-nft-burn-condition branch August 12, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants