Skip to content

Conversation

@rescribet
Copy link
Contributor

@rescribet rescribet commented Oct 14, 2022

@rescribet rescribet force-pushed the cookie-authentication branch from 8c8c90f to e171351 Compare October 14, 2022 14:07
@joepio
Copy link
Member

joepio commented Oct 14, 2022

Thanks for the PR! I think it's a good idea to add an end-to-end test for this. I think this flow should suffice:

  • Create a new drive
  • Press the new file button and upload the demo file
  • Check if the image is visible

This should only work if cookie auth works.

To include the new e2e in this PR, run pnpm build-serverin atomic-data-browser and commit the changes.

@joepio
Copy link
Member

joepio commented Oct 24, 2022

Custom checklist for PR (for some reason the template is missing in this PR)

moved to OP

@rescribet
Copy link
Contributor Author

Updated the test bundle, here the items was already added to the changelog too.

@rescribet rescribet force-pushed the cookie-authentication branch 2 times, most recently from f8c5420 to bebd90e Compare October 24, 2022 12:49
@atomicdata-dev atomicdata-dev deleted a comment from codesandbox bot Oct 26, 2022
@rescribet rescribet force-pushed the cookie-authentication branch from bebd90e to c3f3b20 Compare October 26, 2022 14:20
@joepio
Copy link
Member

joepio commented Oct 26, 2022

Test fails because the expected and actual images are different, because one is Atomic Data and the other Atomic Data Rust

https://github.com/atomicdata-dev/atomic-data-rust/actions/runs/3329831746/jobs/5507547427#step:11:178

@rescribet rescribet force-pushed the cookie-authentication branch from c3f3b20 to 98a5973 Compare October 26, 2022 14:42
@rescribet
Copy link
Contributor Author

Yes, I forgot to update the test config file here

@rescribet rescribet force-pushed the cookie-authentication branch from 98a5973 to 00a9a7a Compare October 26, 2022 14:44
@joepio joepio merged commit 580e43a into master Oct 26, 2022
@joepio joepio deleted the cookie-authentication branch October 26, 2022 15:41
@joepio
Copy link
Member

joepio commented Oct 26, 2022

Thanks @rescribet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants