Cookie authentication bug #525 #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good! I've started deploying this version on Edit: it does! I've updated the OP |
joepio
approved these changes
Oct 28, 2022
| } | ||
| } | ||
|
|
||
| fn origin(url: &str) -> String { |
Member
There was a problem hiding this comment.
does the actix_web::http:Uri not provide this with the authority method?
Might handle some extra edge cases, I'm not sure.
Contributor
Author
There was a problem hiding this comment.
That doesn't include the scheme, so it's not a valid uri (which is the type of the subject field afaict).
| requested_subject: &String, | ||
| ) -> Option<AtomicServerResult<Option<AuthValues>>> { | ||
| let encoded_session = session_cookie_from_header(map.get("Cookie")?)?; | ||
| ) -> AtomicServerResult<Option<AuthValues>> { |
| Some(Err(values.err().unwrap())) | ||
| if subject_invalid { | ||
| return Err(AtomicServerError { | ||
| message: format!( |
Member
There was a problem hiding this comment.
Adding a AtomicServerError::unauthorized creator method might help clean up this code a bit. Not needed to fix now though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
Wrong requested subjectwhen opening atomicdata.dev as agent #527