Skip to content
This repository has been archived by the owner on Nov 9, 2024. It is now read-only.

Fix bug: hovering a hiding content leads to incorrect position. #883

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

zhaoyao91
Copy link
Contributor

@zhaoyao91 zhaoyao91 commented Dec 10, 2020

Currently there is a bug when hovering the hiding content, it will be re-triggered but the position is wrong, since the previous cursor index is lost.

Kapture 2020-12-11 at 01 20 55

This PR fix it by retain the cursor index.

Currently there is a bug when hovering the hiding content, it will be re-triggered but the position is wrong, since the previous cursor index is lost.

This PR fix it by retain the cursor index.
@atomiks
Copy link
Owner

atomiks commented Dec 10, 2020

I think onUntrigger is necessary if you, for example, use the focus trigger afterward. Does that still work fine with this change?

@zhaoyao91
Copy link
Contributor Author

I think onUntrigger is necessary if you, for example, use the focus trigger afterward. Does that still work fine with this change?

Sorry for this missing. I have added onHidden for an alternative and tried that under mouseenter focus it now behaves as previous.

I am not sure is there any other missing, thanks for further checking.

@atomiks atomiks merged commit 8f7b2df into atomiks:master Mar 3, 2021
@zhaoyao91 zhaoyao91 deleted the patch-1 branch March 3, 2021 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants