Added support for ecs credentials #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this. Why is it not merged yet? |
mnd999
approved these changes
Mar 8, 2017
mnd999
suggested changes
Mar 8, 2017
| }).credentials | ||
| credentials ||= Aws::InstanceProfileCredentials.new.credentials | ||
| if opts[:ecs_container_credentials_relative_uri].nil? | ||
| credentials = Aws::SharedCredentials.new({retries: 2}).credentials |
There was a problem hiding this comment.
Don't you want to do credentials ||= Aws::ECSCredentials.new.credentials here as well, in case the config is not specified?
|
@mnd999 should i just close this? |
|
@jc89 why? Afaict it's good. Even with no maintainer to commit it may be useful to others. |
|
Thanks! Also, sorry for the delay in response. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.