feat: add distribution module #181

Pantani · 2025-07-10T18:05:29Z

Add the distribution module from v0.50.13 with some cleanups

api/atomone/distribution/module/v1/module.pulsar.go

tbruyelle · 2025-07-11T14:26:19Z

You should merge again julien/050 to fix the latest tests. You can also merge tbruyelle/chore/lint-upgrade to have a green linter.

That said once merged the IBC setup in the e2e tests is still failing, error is :

e2e_ibc_test.go:167: 
        	Error Trace:	/home/runner/work/atomone/atomone/tests/e2e/e2e_ibc_test.go:167
        	            				/home/runner/work/atomone/atomone/tests/e2e/e2e_setup_test.go:735
        	            				/home/runner/work/atomone/atomone/tests/e2e/e2e_setup_test.go:186
        	            				/home/runner/work/atomone/atomone/tests/e2e/e2e_setup_test.go:192
        	            				/home/runner/work/atomone/atomone/tests/e2e/e2e_test.go:71
        	Error:      	Received unexpected error:
        	            	hermes relayer command failed: failed to create client: error raised while creating client for chain chain-1MAu4z: failed while querying src chain for latest height: RPC error to endpoint http://chain-1mau4z-atomone-00:26657/: response error: Internal error: failed getting app version: app.versionModifier is nil (code: -32603): %!s(<nil>)

I wasn't able to find a fix for now...

giunatale · 2025-07-23T10:35:27Z

@Pantani Some pending conflicts after #141 was updated.

@julienrbrt can you also review this when you have time?

tbruyelle · 2025-08-01T15:26:04Z

I think the pulsar files can be removed, as Julien did in his branch.

# Conflicts: # .golangci.yml # Makefile # app/keepers/keepers.go # app/keepers/keys.go # app/modules.go # tests/e2e/query_test.go

tbruyelle · 2025-08-07T09:27:50Z

proto/atomone/distribution/v1beta1/genesis.proto

@@ -0,0 +1,173 @@
+syntax = "proto3";
+package atomone.distribution.v1beta1;


Since this module is aimed to be part of the fork, is it OK to use the atomone namespace for it ?
In other words, are we going to replace the cosmos namespace to atomone for everything in the fork ?
(for remind, the existing gov module which should also go to the fork already uses the atomone namespace)

This is also my question. IMHO, as a fork but as a different SDK, it will be nice to have different namespaces. But we can lose some integrations we already have for the cosmos-sdk

Indeed, I would rather keep the original namespace, but for x/gov it will difficult to change it back so cosmos, since clients have already integrated the atomone namespace...

Great, I will return the namespaces to cosmos

If you don't mind I prefer to keep the comment unresolved until the namespace is returned to cosmos.

This PR will ideally be done in the SDK? So the buf issues shouldn't happen then.

That's a good point @julienrbrt. Initially we have decided to fork the distribution module in atomone, but given this namespace problem and the fact that now atomone already depends on our SDK fork, we should move the fork of the distribution module directly to our SDK fork, with the cosmos namespace.

@Pantani could you close this PR and make the same on atomone-one/cosmos-sdk ?

Note that for now the atomone gov module will stay on atomone, because it is more closely tied to the AtomOne Constitution.

Note that for now the atomone gov module will stay on atomone, because it is more closely tied to the AtomOne Constitution.

We could port most of the changes to the SDK fork, and keep atom one gov module (for client compat) in atom one as a simple wrapper instead of fork.

Ah yes I remember you told me about this, let's keep that in mind.

# Conflicts: # .golangci.yml # Makefile

tbruyelle

Looks good, but as commented we need to keep the original namespace for protos, because introducing a new one will break client integrations. And considering this module will end up in our fork, this is an other good reason to keep the cosmos namespace.

Pantani · 2025-09-18T18:50:08Z

close because we move this change to atomone cosmos-sdk

atomone-hub/cosmos-sdk#10

Pantani added 24 commits June 23, 2025 02:36

add distribution module

7ee29bc

fix proto paths

2310be2

regenerate pulsar files

d00f411

remove unused and legacy code

5266df2

export mint query server

32e45b7

Merge branch 'julien/050' into feat/dstr-module

0b02f80

rollback unecessary changes

0c12be8

remove unecessary keeper interface

69bf280

fix duplicated error register and makefile check version

88058af

fix distribute reward

88881d0

fix linter

cbdf45c

fix allocation tests

6c5996d

remove mint query server

229a74f

get bound denom from staking module

ea05f4a

improve allocate bonus logic

6211eec

allocation test

e829cd8

fix makefile

7067fb7

fix validate params

3388b61

reollback some cli methods

4f3c853

remove mocks from lint

ee009d0

fix wrong msg paths

1b4154a

Merge branch 'julien/050' into feat/dstr-module

11cca60

fix wrong path

10d31ec

clone distribution module

bda5450

Pantani requested review from giuliostramondo, giunatale, jaekwon and tbruyelle as code owners July 10, 2025 18:05

Pantani added 2 commits July 10, 2025 15:06

rollback check_go_version from Makefile

db6d58f

rollback some generetaed files

eb46bca

rollback gov changes

f19fd5b

github-advanced-security bot found potential problems Jul 10, 2025

View reviewed changes

api/atomone/distribution/module/v1/module.pulsar.go Fixed Show fixed Hide fixed

giunatale mentioned this pull request Jul 11, 2025

feat: ADR-004 (Nakamoto Bonus) #153

Closed

Pantani mentioned this pull request Jul 13, 2025

feat: ADR-004 (Nakamoto Bonus) #182

Closed

Pantani added 3 commits July 16, 2025 15:35

Merge branch 'julien/050' into Pantani/feat/dstr-module

1aba26b

fix lint

3332833

get latest improvements

ea6d970

Pantani force-pushed the Pantani/feat/dstr-module branch 2 times, most recently from 0141f86 to ea6d970 Compare August 4, 2025 06:51

Pantani added 3 commits August 4, 2025 03:55

Merge branch 'julien/050' into Pantani/feat/dstr-module

f02f0e3

# Conflicts: # .golangci.yml # Makefile # app/keepers/keepers.go # app/keepers/keys.go # app/modules.go # tests/e2e/query_test.go

remove pulsar files

794ab3e

remove dreprecated skip files

f7dd803

tbruyelle reviewed Aug 7, 2025

View reviewed changes

Pantani added 4 commits August 11, 2025 18:11

fix cosmos grpc paths

8c5f5aa

Merge branch 'julien/050' into Pantani/feat/dstr-module

e092e68

# Conflicts: # .golangci.yml # Makefile

format proto files

ce96707

format query.proto

48b97ba

Pantani requested a review from tbruyelle August 12, 2025 17:42

tbruyelle requested changes Aug 18, 2025

View reviewed changes

julienrbrt deleted the branch atomone-hub:julien/050 August 25, 2025 15:04

julienrbrt closed this Aug 25, 2025

tbruyelle reopened this Aug 25, 2025

julienrbrt mentioned this pull request Sep 4, 2025

Sync x/gov fork to the v0.50 version #217

Open

tbruyelle mentioned this pull request Sep 18, 2025

feat: ADR-004 (Nakamoto Bonus) atomone-hub/cosmos-sdk#10

Open

Pantani closed this Sep 18, 2025

		@@ -0,0 +1,173 @@
		syntax = "proto3";
		package atomone.distribution.v1beta1;

feat: add distribution module #181

feat: add distribution module #181

Uh oh!

Conversation

Pantani commented Jul 10, 2025

Uh oh!

Uh oh!

tbruyelle commented Jul 11, 2025

Uh oh!

giunatale commented Jul 23, 2025

Uh oh!

tbruyelle commented Aug 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tbruyelle Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

julienrbrt Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tbruyelle left a comment

Choose a reason for hiding this comment

Uh oh!

Pantani commented Sep 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tbruyelle Aug 26, 2025 •

edited

Loading

julienrbrt Aug 28, 2025 •

edited

Loading