Enhanced connection management for esp32 network driver #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermm
reviewed
Jun 7, 2024
| @@ -74,7 +76,8 @@ gotIp(IpInfo) -> | |||
| io:format("Got IP: ~p~n", [IpInfo]). | |||
|
|
|||
| disconnected() -> | |||
| io:format("Disconnected from AP.~n"). | |||
| io:format("Disconnected from AP, attempting to reconnect~n"), | |||
| network:connect(). | |||
There was a problem hiding this comment.
do we need a delay here eg 500-1000ms or something? (ideally exponential backoff - but static delay should be fine..)
There was a problem hiding this comment.
No. This just signals the driver to start attempting a connection, if that attempt succeeds the connected callback will be triggered, otherwise a disconnected callback will be triggered - in which case the attempt will be made again… this would function exactly as the driver always has… by defining a custom callback the user could add any extra delay, or scan for networks instead.
There was a problem hiding this comment.
The only difference is this was connection was called internally, so stop would never be possible. Now by defining a callback the user can control when a reconnection (or now a new connection) will happen.
UncleGrumpy
force-pushed
the
wifi_roaming
branch
from
21fcf76 to
887b3d1
Compare
UncleGrumpy
force-pushed
the
wifi_roaming
branch
from
887b3d1 to
22678d8
Compare
UncleGrumpy
force-pushed
the
wifi_roaming
branch
2 times, most recently
from
246d3b5 to
ae6e359
Compare
UncleGrumpy
force-pushed
the
wifi_roaming
branch
from
ae6e359 to
2611050
Compare
UncleGrumpy
changed the title
UncleGrumpy
force-pushed
the
wifi_roaming
branch
from
2611050 to
be980c2
Compare
UncleGrumpy
force-pushed
the
wifi_roaming
branch
2 times, most recently
from
d95fdf5 to
53a6dc7
Compare
For more fine grained connection management in applications the driver can now be started, without perfoming an inital connection, by the use of the key `managed` in the STA configuration. Adds network:sta_connect/0,1 to allow connecting to an access point after the driver has been started in STA or STA+AP mode. If the function is used without parameters a connection to the last configured access point will be started. Adds network:sta_disconnect/0 to disconnect a station from an access point. The station mode disconnected callback now maintains the default behavior of reconnecting to the last access point if the connection is lost, but if the user defines a custom callback the automatic re-connection will not happen, allowing for users to take advantage of scan results or some other means to determine when and which access point to associate with. The combination of the use of a disconnected callback and `managed` mode allow for the use of `network:wifi_scan/0,1` (PR atomvm#1165), since the wifi must not be connected to a station when perfoming a scan and the current implementation always starts a connection immediatly and always reconnects when disconnected. Signed-off-by: Winford <winford@object.stream>
Adds descriptions of new configuration options and connect/0,1 and disconnect/0 functions. Signed-off-by: Winford <winford@object.stream>
UncleGrumpy
force-pushed
the
wifi_roaming
branch
from
53a6dc7 to
7911e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to stop a connection to an access point, and to start a connection to a new, or the last configured access point. The driver can also enable STA mode without performing an initial connection by supplying the
managedatom in the STA configuration and omitting thessidandpsksettings. Combined with the network scan feature in #1165 this gives the esp32 platform the ability to act as a roaming device, and connect to any known wifi networks found after performing a wifi scan. Thedisconnectedevent callback can be used to override the default automatic re-connect action of the driver, and a network scan or other means may now be used to determine if, when, and which access point to connect to.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later