Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net:gethostname/0 #1411

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Add net:gethostname/0 #1411

merged 1 commit into from
Dec 27, 2024

Conversation

pguyot
Copy link
Collaborator

@pguyot pguyot commented Dec 23, 2024

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@pguyot pguyot force-pushed the w52/add-net-gethostname branch from aedaeb9 to a6ca783 Compare December 25, 2024 07:09
@pguyot pguyot force-pushed the w52/add-net-gethostname branch from a6ca783 to b9db8ed Compare December 26, 2024 12:42
@pguyot pguyot marked this pull request as ready for review December 26, 2024 12:43
Copy link
Collaborator

@bettio bettio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks ok, I just a couple of very minor notes.
Anyway tomorrow I will merge main into feature/distributed-erlang, so it might be a good idea to target main since it is very general and self contained.

src/libAtomVM/otp_net.c Outdated Show resolved Hide resolved
src/libAtomVM/otp_net.c Outdated Show resolved Hide resolved
@pguyot pguyot changed the base branch from feature/distributed-erlang to main December 27, 2024 07:40
Signed-off-by: Paul Guyot <pguyot@kallisys.net>
@pguyot pguyot force-pushed the w52/add-net-gethostname branch from b9db8ed to 1fcd025 Compare December 27, 2024 07:41
}

term result = term_alloc_tuple(2, &ctx->heap);
term_put_tuple_element(result, 0, OK_ATOM);

Check failure

Code scanning / CodeQL

Passing a non-term to a function expecting a term Error

Passing a non-term to a function expecting a term, without an explicit cast
@bettio bettio merged commit 55394d9 into atomvm:main Dec 27, 2024
96 of 104 checks passed
@pguyot pguyot deleted the w52/add-net-gethostname branch December 27, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants