Make defaultatoms.h/.c easier to maintain #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
commented
Dec 24, 2024
bettio
force-pushed
the
make-defaultatoms-maintainable
branch
5 times, most recently
from
7e64af8 to
14b1b29
Compare
Just keep one list of atoms, and use the old good X macro trick https://en.wikipedia.org/wiki/X_macro Signed-off-by: Davide Bettio <davide@uninstall.it>
No need to make a lot of checks: default atoms insertion is not error prone anymore. Signed-off-by: Davide Bettio <davide@uninstall.it>
Using same approach used in defaultatoms also for ESP32 platform ones. Signed-off-by: Davide Bettio <davide@uninstall.it>
Using same approach used in defaultatoms also for generic_unix platform ones. Signed-off-by: Davide Bettio <davide@uninstall.it>
bettio
force-pushed
the
make-defaultatoms-maintainable
branch
from
14b1b29 to
5363c44
Compare
bettio
added a commit
that referenced
this pull request
Dec 27, 2024
CodeQL: Fix _ATOM handling in non-term-to-term-func After #1413, CodeQL was reporting a lot of noise. These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license). SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just keep one list of atoms, and use the old good X macro trick https://en.wikipedia.org/wiki/X_macro
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later