Add float/1 BIF #1518
Merged
Add float/1 BIF #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
pguyot
requested changes
Feb 9, 2025
bettio
reviewed
Feb 10, 2025
Collaborator
bettio
left a comment
bettio
left a comment
There was a problem hiding this comment.
Looks good, let's add it to the Unreleased / Added changelog section.
jgonet
force-pushed
the
jgonet/float-1-avm
branch
from
ba7744a to
933f930
Compare
bettio
approved these changes
Feb 12, 2025
bettio
requested changes
Feb 12, 2025
Collaborator
There was a problem hiding this comment.
I apologize, I realized too late this PR was targeting the wrong branch / release.
We are not going to add new features to release-0.6: v0.6.x is a maintenance branch mainly focused on bug fixes.
I suggest to rebase it on top of main branch, and move the changelog entry to "Unreleased" / "Added".
Sorry for the inconvenience.
Signed-off-by: Jakub Gonet <jakub.gonet@swmansion.com>
jgonet
force-pushed
the
jgonet/float-1-avm
branch
from
933f930 to
8c519cd
Compare
bettio
approved these changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #1509
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later