Add erlang:is_record/2
#1564
Add erlang:is_record/2
#1564
Conversation
bettio
left a comment
bettio
left a comment
There was a problem hiding this comment.
Some minor changes are required.
Also it look something that we really missed in release-0.6, if it doesn't take you too much time I would rebase this on top of release-0.6. In that case let's also update the changelog.
src/libAtomVM/bifs.gperf
Outdated
| erlang:is_pid/1, {.bif.base.type = BIFFunctionType, .bif.bif1_ptr = bif_erlang_is_pid_1} | ||
| erlang:is_reference/1, {.bif.base.type = BIFFunctionType, .bif.bif1_ptr = bif_erlang_is_reference_1} | ||
| erlang:is_tuple/1, {.bif.base.type = BIFFunctionType, .bif.bif1_ptr = bif_erlang_is_tuple_1} | ||
| erlang:is_record/2,{.bif.base.type = BIFFunctionType, .bif.bif2_ptr = bif_erlang_is_record} |
There was a problem hiding this comment.
question: do we know if is_record/3 is used in any context?
There was a problem hiding this comment.
We didn't come across any usage, I didn't want to add it preemptively.
jgonet
force-pushed
the
jgonet/is-record
branch
from
683621c to
5344799
Compare
bettio
left a comment
bettio
left a comment
There was a problem hiding this comment.
Let's make sure we are compatible with BEAM behavior.
Last, before commiting the fixed version, let's run erlfmt in order to make sure that sources are properly formatted.
|
A number of CI fixes has been made in release-0.6. Let's rebase it on latest release-0.6. |
jgonet
force-pushed
the
jgonet/is-record
branch
3 times, most recently
from
8f7f9a8 to
8274823
Compare
jgonet
force-pushed
the
jgonet/is-record
branch
from
8274823 to
fe7261d
Compare
bettio
left a comment
bettio
left a comment
There was a problem hiding this comment.
Sorry, I found a last minute compatibility issue with OTP.
jgonet
force-pushed
the
jgonet/is-record
branch
from
fe7261d to
370559b
Compare
Signed-off-by: Jakub Gonet <jakub.gonet@swmansion.com>
jgonet
force-pushed
the
jgonet/is-record
branch
from
370559b to
1b64297
Compare
4 participants
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later