JIT: fix register leak in first_pass_bs_match_equal_colon_equal #1887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a leak where a register was not properly freed on 32 bits platforms. Also fix a double free that happened on 32 bits platforms. This code currently is dead and is only evaluated when targeting riscv-32 and armv6m. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w41/jit-fix-register-leak-32bits
branch
from
0988e0e to
8f81439
Compare
bettio
approved these changes
Oct 12, 2025
bettio
added a commit
that referenced
this pull request
Oct 22, 2025
Just in time compilation with armv6m target Continuation of: - #1770 - #1773 - #1833 - #1834 - #1835 - #1890 - #1878 - #1881 - #1887 The target is suitable for Pico, Pico2 and STM32. Benchmark test on a Pico with SMP disabled shows a speed increase from 14% to 62%. | native (w34/jit-arm) | emulated (main) -- d8ecc02 | % -- | -- | -- | -- pingpong_speed_test | 17437587 | 27590085 | 37 % prime_speed_test | 13257293 | 35212412 | 62 % prng_test | 1128949 | 1500967 | 25 % pi_test | 26759537 | 58693061 | 54 % sudoku_solution_test | 6420801 | 7471461 | 14 % sudoku_puzzle_test | 254335968 | 333834045 | 24 % Remark: the current backend requires 64 bits floats. 32 bits floats would need a specific variant. These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license). SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a leak where a register was not properly freed on 32 bits platforms
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later