Make test_epmd more robust by performing an actual query on epmd
#2011
+20
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w48/make-test_epmd-more-robust
branch
2 times, most recently
from
4d2b6f3 to
c480b1f
Compare
test_epmd ensured that epmd is running on CI by trying to connect to it. However, in some cases, this connection test succeeded while epmd would not be ready yet and would close the socket when trying to register. See for example this run: https://github.com/pguyot/AtomVM/actions/runs/19780234793/job/56679370750 Replace test with querying for registered nodes to ensure epmd is indeed ready. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w48/make-test_epmd-more-robust
branch
from
c480b1f to
f93e37f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_epmd ensured that epmd is running on CI by trying to connect to it. However, in some cases, this connection test succeeded while epmd would not be ready yet and would close the socket when trying to register. See for example this run: https://github.com/pguyot/AtomVM/actions/runs/19780234793/job/56679370750
Replace test with querying for registered nodes to ensure epmd is indeed ready.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later